Skip to content

Fix CI: run ruff check --fix#187

Draft
stisa wants to merge 1 commit into
compas-dev:masterfrom
stisa:patch-1
Draft

Fix CI: run ruff check --fix#187
stisa wants to merge 1 commit into
compas-dev:masterfrom
stisa:patch-1

Conversation

@stisa
Copy link
Copy Markdown

@stisa stisa commented May 5, 2026

Comply with ruff lint so that hopefully CI will build packages again

Edit: seems like this is more complex than it seemed, there are also a bunch of errors from the type check, see: https://github.com/stisa/compas_slicer/actions/runs/25364385163/job/74371415800
I'll convert this to a draft for now until I have time to go through it

What type of change is this?

  • Bug fix in a backwards-compatible manner.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Comply with ruff lint
@stisa stisa marked this pull request as draft May 5, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant